Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to IJP 242 EAP #391

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Switch to IJP 242 EAP #391

merged 1 commit into from
Jul 2, 2024

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented May 27, 2024

This in turn requires:

  1. Updating Kotlin to 1.9.24 (matching the bundled version)
  2. Updating the IJP Gradle plugin to 2.0 (beta)
  3. Updating Gradle (not mandatory, but why not)
  4. Updating Compose to 1.6.20-dev1646
  5. Reworking the IDE sample build.gradle.kts in the new 2.0 syntax
  6. Bumping the JBR version to 21

Closes #389 — the releases/241 branch was created from main after #390 was merged.

Note: we disabled the CodeQL checks because no matter what, they tried building with the JDK 11 instead of 21, which is now required. So long, CodeQL.

@rock3r rock3r self-assigned this May 27, 2024
@rock3r rock3r force-pushed the upgrade-to-242 branch 2 times, most recently from d685c77 to 4e2863f Compare May 27, 2024 14:43
@rock3r rock3r force-pushed the upgrade-to-242 branch 2 times, most recently from 9d79a24 to e576dde Compare July 2, 2024 15:16
@rock3r rock3r force-pushed the upgrade-to-242 branch 3 times, most recently from a86eff7 to 03cb95b Compare July 2, 2024 15:54
@rock3r rock3r marked this pull request as ready for review July 2, 2024 16:02
@rock3r rock3r requested a review from hamen July 2, 2024 16:02
This in turn requires:
1. Updating the IJP Gradle plugin to 2.0 (beta)
2. Reworking the IDE sample build.gradle.kts in the new 2.0 syntax
3. Bumping the JBR version to 21
4. Removing CodeQL (we're not using it, it's slow, and it won't pick up
   a JDK 21 no matter how much you want it to)
Copy link
Collaborator

@hamen hamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪✌️

@rock3r rock3r merged commit 4ef7ad2 into main Jul 2, 2024
4 checks passed
@rock3r rock3r deleted the upgrade-to-242 branch July 2, 2024 16:49
hamen pushed a commit that referenced this pull request Jul 8, 2024
This in turn requires:
1. Updating the IJP Gradle plugin to 2.0 (beta)
2. Reworking the IDE sample build.gradle.kts in the new 2.0 syntax
3. Bumping the JBR version to 21
4. Removing CodeQL (we're not using it, it's slow, and it won't pick up
   a JDK 21 no matter how much you want it to)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move main branch to 242
2 participants